Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RemoteQueue handles duplicates #552

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: RemoteQueue handles duplicates #552

wants to merge 1 commit into from
+22 −0

Conversation

dorjesinpo
Copy link
Collaborator

The following broadcast sequence

  1. m1 arrives, gets inserted, does go out, d_appData is null
  2. m2 with the same GUID arrives, does not get inserted (duplicate), does go out
  3. upstream is lost
  4. soft NACK arrives for m1, data goes back to d_appData
  5. soft NACK arrives for m2, d_appData is not null

...results in the assert

@dorjesinpo dorjesinpo added the bug Something isn't working label Dec 20, 2024
@dorjesinpo dorjesinpo requested a review from a team as a code owner December 20, 2024 18:45
@dorjesinpo dorjesinpo changed the title RemoteQueue handles duplicates fix: RemoteQueue handles duplicates Dec 20, 2024
pniedzielski
pniedzielski approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@pniedzielski pniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pniedzielski pniedzielski pniedzielski approved these changes

Assignees

@pniedzielski pniedzielski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorjesinpo @pniedzielski