Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat[Storagetool]: Add support of queueOp and journalOp records #531

Open
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

alexander-e1off
Copy link
Collaborator

@alexander-e1off alexander-e1off commented Nov 26, 2024

Enhance storage tool to search queueOp and journalOp records (in addition to message records). New option to select record type is introduced:

  -r | --record-type          <record-type>
          record type to search {message|queue-op|journal-op} (default: message)

To search multiple record types, this option should be repeated, e.g. -r message -r queue-op.

In the short form, output of new records looks like the following:

[ header = [ type = QUEUE_OP flags = 0 primaryLeaseId = 2 sequenceNumber = 2 timestamp = 1732618118 ] flags = 0 queueKey = 44D469EF30 appKey = 0000000000 type = CREATION queueUriRecordOffsetWords = 9 ]
[ header = [ type = JOURNAL_OP flags = 0 primaryLeaseId = 2 sequenceNumber = 3 timestamp = 1732618119 ] flags = 0 type = SYNCPOINT syncPointType = REGULAR sequenceNum = 3 primaryNodeId = 0 primaryLeaseId = 2 dataFileOffsetDwords = 5 qlistFileOffsetWords = 47 ]

In the detail form (with option --details), output of new records looks like the following:

=========================================
JOURNAL_OP record, index: 12, offset: 764
    PrimaryLeaseId        : 4
    SequenceNumber        : 1
    Timestamp             : 26NOV2024_11:03:35.000000
    Epoch                 : 1732619015
    JournalOpType         : SYNCPOINT
    SyncPointType         : REGULAR
    SyncPtPrimaryLeaseId  : 0
    SyncPtSequenceNumber  : 1
    PrimaryNodeId         : 4
    DataFileOffsetDwords  : 8

=======================================
QUEUE_OP record, index: 13, offset: 824
    PrimaryLeaseId     : 4
    SequenceNumber     : 2
    Timestamp          : 26NOV2024_11:03:59.000000
    Epoch              : 1732619039
    QueueKey           : 676EC94E89
    QueueUri           : bmq://bmq.test.persistent.fanout/my2
    AppKey             : ** NULL **
    AppId              : ** NULL **
    QueueOpType        : CREATION
    QLIST OffsetWords  : 47

Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
Signed-off-by: Aleksandr Ivanov <[email protected]>
@pniedzielski
Copy link
Collaborator

@alexander-e1off, is this ready to be reviewed? It looks like some tests are failing with build errors.

@alexander-e1off
Copy link
Collaborator Author

alexander-e1off commented Dec 5, 2024

@alexander-e1off, is this ready to be reviewed? It looks like some tests are failing with build errors.

@pniedzielski, this PR depends on #508 and will be ready for review as soon as #508 is merged. Please review it first. Thanks.

Copy link
Collaborator

@pniedzielski pniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I can tell pre-rebase. Once you rebase, I'll double check and approve.

@alexander-e1off alexander-e1off marked this pull request as ready for review December 20, 2024 18:08
@alexander-e1off alexander-e1off requested a review from a team as a code owner December 20, 2024 18:08
@alexander-e1off
Copy link
Collaborator Author

@pniedzielski, I've rebased, so you can double check. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants