Merge pull request #38 from blocknotes/fix-duplicated-before-content

Send the `li` before content only once
blocknotes · May 3, 2022 · 81c7b2d · 81c7b2d
2 parents ffc1dd2 + 8d3bb21
commit 81c7b2d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/examples/random_content.html b/examples/random_content.html
@@ -63,7 +63,7 @@ <h1>Random content <small>(with various elements and styles)</small></h1>
       Li 2
       <ol>
         <li>Li 2 - 1</li>
-        <li>Li 2 - 2</li>
+        <li>Text that is <b>bold</b> and <i>italic</i> also.</li>
         <li>Li 2 - 3</li>
       </ol>
     </li>

diff --git a/examples/random_content.pdf b/examples/random_content.pdf
diff --git a/lib/prawn_html/document_renderer.rb b/lib/prawn_html/document_renderer.rb
@@ -106,7 +106,8 @@ def apply_tag_open_styles(element)
     end
 
     def prepare_text(content)
-      text = context.before_content ? ::Oga::HTML::Entities.decode(context.before_content) : ''
+      before_content = context.before_content
+      text = before_content ? ::Oga::HTML::Entities.decode(before_content) : ''
       return (@last_text = text + content) if context.white_space_pre?
 
       content = content.lstrip if @last_text[-1] == ' ' || @last_tag_open

diff --git a/lib/prawn_html/tags/li.rb b/lib/prawn_html/tags/li.rb
@@ -13,7 +13,9 @@ def block?
       end
 
       def before_content
-        @counter ? "#{@counter}. " : "#{@symbol} "
+        return if @before_content_once
+
+        @before_content_once = @counter ? "#{@counter}. " : "#{@symbol} "
       end
 
       def block_styles