-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carthage support #41
base: master
Are you sure you want to change the base?
Carthage support #41
Conversation
arturgrigor
commented
Mar 20, 2017
•
edited
Loading
edited
- Added framework and test schemes for each supported platform.
- Made the schemes Shared for Carthage support.
- Deintegrated CocoaPods.
- Added the Kiwi dependency as a git submodule.
- Bumped the pod version.
- Raised the minimum deployment version to 6.0 to support bitcode.
…e schemes Shared for Carthage support. Embedded the Pods in the repo for Carthage build support. Upgraded the Podfile. Bumped the pod version. Raised the minimum deployment version to 6.0 to support bitcode.
Nice job getting the tests working! However, rather than include the Pods directory in the repository, I would suggest instead that you create |
…rthage dependecy. Updated the Travis CI config to use Carthage. Bumped the podspec version to 2.2.3. Updated the project settings to the recommended settings.
Thanks @weissazool! I've made those changes but for some reason Travis CI doesn't use the proper .travis.yml config for the latest commits but you can check the status of the build for my fork here: https://travis-ci.org/arturgrigor/TransitionKit/builds/233918533. |
@arturgrigor Great! I have a question, though. If you remove the Podfile and the Podfile.lock, won't it no longer be possible to add this framework via Cocoapods, since it won't be able to fetch its dependencies? Also, the Carthage directory should probably be added to |
@weissazool no, removing the Podfile doesn't affect that at all because the installation uses the Yeah, I guess you're right with the |
@arturgrigor I see. But for any existing users, there's no guarantee that they will have Carthage. Since the primary method of integration up until now has been Cocoapods, it's quite likely that they have that. My concern is that this would break this part of the readme for any current users of this framework. |
@weissazool That wouldn't be affected at all because when you install this framework using CocoaPods it uses the But don't worry because I did a few changes and I added the |
@blakewatters can you please take a look at this small PR? The whole purpose of this PR is to add Carthage support to this project and in order to do so I have followed the setup from AlamofireImage for building the project and linking the dependencies. |