Improve logic for finding svg content #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr5hn
changed the title
|
Can you add a much more smaller svg? This is quite too much lines.. |
|
@driesvints Ok will try to compress it to smaller. |
|
@dr5hn I see your force push but the SVG contents are still the same. I can't merge this in as is sorry. Can you please re-send the PR with a much smaller SVG? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Stripping tags sometimes doesn't match the content when doing
str_replace. Hence it fails applying defer functionality.Solution
Introducing a regex extraction fixes the issue.