Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic chat members completer and fix segfault on ui close #150

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

elros34
Copy link
Contributor

@elros34 elros34 commented Mar 9, 2020

Amount of chat members for one query is limited to 200 by tdlib but that should be enough for usual use case.

elros34 added 2 commits March 12, 2020 18:31
Add human readable way to create tdlib json queries
@blacksailer
Copy link
Owner

Hello! thanks for your pull request! I've merged it to 0.7.6. (Noticed your forced pushed update, will check it too)
I want to add support to multiple username mentioning, because it works only on start. Do you have any ideas for implemetation? Because we need to understand what user is typing.

@elros34
Copy link
Contributor Author

elros34 commented Mar 14, 2020

Thanks, I didn't think you will merge it before I remove WIP from title. I basically forced pushed changes to group/channel info page because my previous implementation with one ListView + header worked poorly in some cases.
I wrote some code to handle @username in any place but not everything works correctly yet. I will see if I can fix it.

@elros34 elros34 changed the title WIP Implement basic chat members completer and fix segfault on ui close Implement basic chat members completer and fix segfault on ui close Mar 20, 2020
@elros34
Copy link
Contributor Author

elros34 commented Mar 20, 2020

@username should works now in any place when writing message provided that previous character is not alphanumeric. I didn't check official telegram application sources but looks like it works similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants