Break up complex method into two (#1103)

blackducksoftware · Apr 29, 2024 · 256bf78 · 256bf78
1 parent ca180ce
commit 256bf78
Showing 1 changed file with 21 additions and 17 deletions.
diff --git a/...om/synopsys/integration/detectable/detectables/poetry/parser/ToolPoetrySectionParser.java b/...om/synopsys/integration/detectable/detectables/poetry/parser/ToolPoetrySectionParser.java
@@ -55,29 +55,33 @@ public Set<String> parseRootPackages(File pyprojectToml, PoetryOptions options)
         }
 
         for (String key : parseResult.dottedKeySet(true)) {
-            if (!parseResult.isTable(key)) {
-                continue;
-            }
+            processKeyForRootPackages(parseResult, options, result, key);
+        }
+
+        result.remove(PYTHON_COMPONENT_NAME);
+        return result;
+    }
+
+    private void processKeyForRootPackages(TomlParseResult parseResult, PoetryOptions options, Set<String> result, String key) {
+        if (!parseResult.isTable(key)) {
+            return;
+        }
 
-            TomlTable table = parseResult.getTable(key);
+        TomlTable table = parseResult.getTable(key);
 
-            if (key.equals(MAIN_DEPENDENCY_GROUP_KEY)) {
+        if (key.equals(MAIN_DEPENDENCY_GROUP_KEY)) {
+            addAllTableKeysToSet(result, table);
+        } else if (key.equals(LEGACY_DEV_DEPENDENCY_GROUP_KEY)) { // in Poetry 1.0 to 1.2 this was the way of specifying dev dependencies
+            if (!options.getExcludedGroups().contains(DEFAULT_DEV_GROUP_NAME)) {
                 addAllTableKeysToSet(result, table);
-            } else if (key.equals(LEGACY_DEV_DEPENDENCY_GROUP_KEY)) { // in Poetry 1.0 to 1.2 this was the way of specifying dev dependencies
-                if (!options.getExcludedGroups().contains(DEFAULT_DEV_GROUP_NAME)) {
-                    addAllTableKeysToSet(result, table);
-                }
-            } else if (key.startsWith(DEPENDENCY_GROUP_KEY_PREFIX) && key.endsWith(DEPENDENCY_GROUP_KEY_SUFFIX)) {
-                String group = key.substring(DEPENDENCY_GROUP_KEY_PREFIX.length(), key.length() - DEPENDENCY_GROUP_KEY_SUFFIX.length());
+            }
+        } else if (key.startsWith(DEPENDENCY_GROUP_KEY_PREFIX) && key.endsWith(DEPENDENCY_GROUP_KEY_SUFFIX)) {
+            String group = key.substring(DEPENDENCY_GROUP_KEY_PREFIX.length(), key.length() - DEPENDENCY_GROUP_KEY_SUFFIX.length());
 
-                if (!options.getExcludedGroups().contains(group)) {
-                    addAllTableKeysToSet(result, table);
-                }
+            if (!options.getExcludedGroups().contains(group)) {
+                addAllTableKeysToSet(result, table);
             }
         }
-
-        result.remove(PYTHON_COMPONENT_NAME);
-        return result;
     }
 
     private void addAllTableKeysToSet(Set<String> set, TomlTable table) {