[14기 이하은] step2 상태 관리로 메뉴 관리하기 #287
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,81 +1,137 @@ | ||||||||
| import { $, $id } from './utils/dom.js'; | ||||||||
| import LocalStorage from './utils/localStorage.js' | ||||||||
|
|
||||||||
| function App () { | ||||||||
| const MenuListStorage = new LocalStorage('menuList'); | ||||||||
|
|
||||||||
| // states | ||||||||
| // [{name: string; category: string; isSoldOut: boolean;}] | ||||||||
| let menuList = MenuListStorage.get() ?? []; | ||||||||
| let category = 'espresso'; | ||||||||
|
|
||||||||
| window.onload = () => { | ||||||||
| initEventListenes(); | ||||||||
| renderAboutMenus(); | ||||||||
| }; | ||||||||
|
|
||||||||
| // utils | ||||||||
| const getMenuId = (target) => { | ||||||||
| return Number(target.parentElement.dataset.menuId); | ||||||||
| }; | ||||||||
|
|
||||||||
| // events | ||||||||
| const addMenu = () => { | ||||||||
| let name = $id('menu-name').value?.trim(); | ||||||||
| if (!name) return; | ||||||||
|
|
||||||||
| menuList = [...menuList, {name, category}]; | ||||||||
|
There was a problem hiding this comment. 여기서 |
||||||||
| MenuListStorage.set(menuList); | ||||||||
| renderAboutMenus(); | ||||||||
| $id('menu-name').value = ''; | ||||||||
| }; | ||||||||
|
|
||||||||
| const editMenu = ({target}) => { | ||||||||
| const name = window.prompt('메뉴명을 수정하세요').trim(); | ||||||||
| if (!name) return; | ||||||||
|
|
||||||||
| const menuId = getMenuId(target); | ||||||||
| menuList = menuList.map((menu, index) => index === menuId ? {...menu, name} : menu); | ||||||||
|
|
||||||||
| MenuListStorage.set(menuList); | ||||||||
| renderAboutMenus(); | ||||||||
| }; | ||||||||
|
|
||||||||
| const removeMenu = ({target}) => { | ||||||||
| if (!window.confirm('정말 삭제하시겠습니까?')) return; | ||||||||
|
|
||||||||
| const menuId = getMenuId(target); | ||||||||
| menuList = menuList.filter((_, index) => index !== menuId); | ||||||||
|
There was a problem hiding this comment. menuList를 변경하고, 로컬스토리지에 저장하는 작업이 반복적으로 사용이 되고있는데요, 함수로 따로 관리한다면 더 좋을것 같아요! |
||||||||
| MenuListStorage.set(menuList); | ||||||||
| renderAboutMenus(); | ||||||||
| }; | ||||||||
|
|
||||||||
| const toggleIsSoldOut = ({target}) => { | ||||||||
| const menuId = getMenuId(target); | ||||||||
| menuList = menuList.map((menu, index) => | ||||||||
| index === menuId ? {...menu, isSoldOut: !menu.isSoldOut} : menu, | ||||||||
|
There was a problem hiding this comment.
|
||||||||
| ); | ||||||||
| MenuListStorage.set(menuList); | ||||||||
| renderAboutMenus(); | ||||||||
| }; | ||||||||
|
|
||||||||
| const setCategory = ({target}) => { | ||||||||
| const selectedCategory = target.dataset.categoryName; | ||||||||
| category = selectedCategory; | ||||||||
|
Comment on lines
+62
to
+63
There was a problem hiding this comment.
Suggested change
이렇게 선언하지 않은건 |
||||||||
| $id('category-title').textContent = `${target.textContent} 메뉴 관리`; | ||||||||
| renderAboutMenus(); | ||||||||
| }; | ||||||||
|
|
||||||||
| // addEventListeners | ||||||||
| const initEventListenes = () => { | ||||||||
| const $form = $id('menu-form'); | ||||||||
| $form.addEventListener('submit', (e) => { | ||||||||
| e.preventDefault(); | ||||||||
| addMenu(); | ||||||||
| }); | ||||||||
|
|
||||||||
| const $menu = $id('menu-list'); | ||||||||
| $menu.addEventListener('click', (e) => { | ||||||||
| switch (e.target.dataset.action) { | ||||||||
| case 'edit': | ||||||||
| editMenu(e); | ||||||||
| return; | ||||||||
| case 'remove': | ||||||||
| removeMenu(e); | ||||||||
| return; | ||||||||
| case 'sold-out': | ||||||||
| toggleIsSoldOut(e); | ||||||||
| return; | ||||||||
| } | ||||||||
| }); | ||||||||
|
|
||||||||
| const $categoryList = $id('cafe-category-name-list'); | ||||||||
| $categoryList.addEventListener('click', setCategory); | ||||||||
| }; | ||||||||
|
|
||||||||
| // renders | ||||||||
| const renderAboutMenus = () => { | ||||||||
| const menuListTemplate = menuList | ||||||||
| .filter(menu => menu.category === category) | ||||||||
| .map((menu, index) => { | ||||||||
| return ` | ||||||||
| <li data-menu-id="${index}" class="menu-list-item d-flex items-center py-2"> | ||||||||
| <span class="w-100 pl-2 menu-name${menu.isSoldOut ? ' sold-out' : ''}">${menu.name}</span> | ||||||||
|
There was a problem hiding this comment. "sold-out" class 앞의 공백을 삼항연산자 안이 아니라
Suggested change
|
||||||||
| <button | ||||||||
| type="button" | ||||||||
| data-action="sold-out" | ||||||||
| class="bg-gray-50 text-gray-500 text-sm mr-1 menu-sold-out-button" | ||||||||
| > | ||||||||
| 품절 | ||||||||
| </button> | ||||||||
| <button | ||||||||
| type="button" | ||||||||
| data-action="edit" | ||||||||
| class="bg-gray-50 text-gray-500 text-sm mr-1 menu-edit-button" | ||||||||
| > | ||||||||
| 수정 | ||||||||
| </button> | ||||||||
| <button | ||||||||
| type="button" | ||||||||
| data-action="remove" | ||||||||
| class="bg-gray-50 text-gray-500 text-sm menu-remove-button" | ||||||||
| > | ||||||||
| 삭제 | ||||||||
| </button> | ||||||||
| </li> | ||||||||
| ` | ||||||||
| }); | ||||||||
| $id('menu-list').innerHTML = menuListTemplate.join(''); | ||||||||
|
|
||||||||
| renderMenuCount(menuListTemplate.length); | ||||||||
| }; | ||||||||
|
|
||||||||
| const renderMenuCount = (count) => { | ||||||||
| $('.menu-count').textContent = `총 ${count}개`; | ||||||||
| }; | ||||||||
| } | ||||||||
|
|
||||||||
| App(); | ||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export const $ = (selector) => document.querySelector(selector); | ||
|
|
||
| export const $id = (id) => document.getElementById(id); | ||
|
There was a problem hiding this comment.
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| export default class LocalStorage { | ||
|
There was a problem hiding this comment. 저는 단순히 util함수로 만들어서 로컬스토리지를 관리했는데 이 방법도 좋은것 같아요!👍 |
||
|
|
||
| constructor(key) { | ||
| this.key = key; | ||
| } | ||
|
|
||
| get () { | ||
| return JSON.parse(localStorage.getItem(this.key)); | ||
| } | ||
|
|
||
| set (value) { | ||
| return localStorage.setItem(this.key, JSON.stringify(value)); | ||
| } | ||
|
|
||
| remove (){ | ||
| localStorage.removeItem(this.key); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??라는게 있었네요! 저는||를 쓰는데 앞으로는??를 써야겠어요! 감사합니다~!😀