Step bundle inputs #1045
Draft
Step bundle inputs #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godrei
commented
Jan 24, 2025
| @@ -85,7 +85,6 @@ func (r WorkflowRunner) activateAndRunSteps( | |||
|
|
|||
| // Global variables for restricting Step Bundle's environment variables for the given Step Bundle | |||
| currentStepBundleUUID := "" | |||
| // TODO: add the last step bundle's envs to environments | |||
There was a problem hiding this comment.
This comment seemed obsolete, we even have a test case to check if the last step bundle's output env vars are available: https://github.com/bitrise-io/bitrise/blob/master/cli/run_test.go#L708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MINOR version update
Context
This PR introduces
inputsfor Step Bundles.Currently, Step Bundles can be configured with
envs. The newinputsare meant to replaceenvsin the future to unify how different entities in bitrise.yml can be configured.Step Bundle related analytics are under an update to contain information about the actual usage of Step Bundle
envs, based on the data we either just removeenvsfrom bitrise.yml or deprecate it in a later PR. For nowinputsandenvslive next to each other, butinputshave priority overenvs(a Step Bundle input overrides a Step Bundle env with the same key).The only difference between inputs and envs is that inputs need to be defined on the step bundle, to be able to step value when used in a workflow.