Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified edge-to-edge-configuration #493

Merged

Conversation

ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented Jan 28, 2025

Purpose

Fixes #490

Short description

Simplified the whole edge-to-edge configuration. Now it's always "dark" for the status bar. Icons should always be white.

Skipped all the scrim thing because it just doesn't work well.

Light Mode

light-mode

Dark Mode

dark-mode

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ ArnyminerZ linked an issue Jan 28, 2025 that may be closed by this pull request
@ArnyminerZ ArnyminerZ self-assigned this Jan 28, 2025
@ArnyminerZ ArnyminerZ added the bug Something isn't working label Jan 28, 2025
@ArnyminerZ ArnyminerZ requested a review from sunkup January 28, 2025 11:09
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sunkup sunkup merged commit d273fce into dev Jan 29, 2025
11 checks passed
@sunkup sunkup deleted the 490-bottom-bar-navigation-controls-are-dark-on-dark-backgroud branch January 29, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom bar navigation controls are dark on dark backgroud
2 participants