Print satoshi amounts in all tests #661
Merged
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK 6b8b1b6 Looks straightforward to me |
thunderbiscuit
force-pushed
the
fix/tests
branch
from
6b8b1b6 to
db80ed6
Compare
|
@reez I just need an "approve" and I can merge... |
reez
approved these changes
Feb 4, 2025
|
omg dude I'm getting legendary with this approve button thing. this PR has been approve buttoned now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes to print statements I keep seeing when I run tests locally, where we print statement shows the
Amounttype name instead of the satoshi amount.Python was also giving me a ton of grief because of the new requirements that packages be installed at the virtual environment level rather than globally (not a bad thing, just a darn mess to deal with when you're not writing Python all day every day). Anyway I created a local virtual environment that I will leave in my repo for ease of use but I needed to add that to the gitignore.