DRAFT: Custom data directory support #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnny9
reviewed
Feb 25, 2023
There was a problem hiding this comment.
Here is the error output for the android apk
02-25 08:51:21.967 32529 32551 W libbitcoin-qt_arm64-v8a.so: QQmlApplicationEngine failed to load component
02-25 08:51:21.967 32529 32551 W libbitcoin-qt_arm64-v8a.so: qrc:/qml/pages/main.qml:38:13: Type OnboardingStorageLocation unavailable
02-25 08:51:21.967 32529 32551 W libbitcoin-qt_arm64-v8a.so: qrc:/qml/pages/onboarding/OnboardingStorageLocation.qml:25:17: Type StorageLocations unavailable
02-25 08:51:21.967 32529 32551 W libbitcoin-qt_arm64-v8a.so: qrc:/qml/components/StorageLocations.qml:34:5: Type FileDialog unavailable
02-25 08:51:21.968 32529 32551 W libbitcoin-qt_arm64-v8a.so: qrc:/qt-project.org/imports/QtQuick/Dialogs/DefaultFileDialog.qml:45:1: module "QtQuick.Dialogs.Private" is not installed
|
Here is the error output for the android apk
It looks like expected considering Lines 55 to 57 in 1e9981d |
|
Maybe diff --git a/build-aux/m4/bitcoin_qt.m4 b/build-aux/m4/bitcoin_qt.m4
index e12d2efa6..5b1a133c1 100644
--- a/build-aux/m4/bitcoin_qt.m4
+++ b/build-aux/m4/bitcoin_qt.m4
@@ -236,6 +236,7 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
_BITCOIN_QT_CHECK_STATIC_PLUGIN([QtQuickLayoutsPlugin], [-lqml_QtQuick_Layouts_qquicklayoutsplugin])
dnl qtquickcontrols module plugins
_BITCOIN_QT_CHECK_STATIC_PLUGIN([QtQuick2DialogsPlugin], [-lqml_QtQuick_Dialogs_dialogplugin])
+ _BITCOIN_QT_CHECK_STATIC_PLUGIN([QtQuick2DialogsPrivatePlugin], [-lqml_QtQuick_Dialogs_Private_dialogsprivateplugin])
_BITCOIN_QT_CHECK_STATIC_PLUGIN([QtQuickControls1Plugin], [-lqml_QtQuick_Controls_qtquickcontrolsplugin])
_BITCOIN_QT_CHECK_STATIC_PLUGIN([QmlFolderListModelPlugin], [-lqml_Qt_labs_folderlistmodel_qmlfolderlistmodelplugin])
_BITCOIN_QT_CHECK_STATIC_PLUGIN([QmlSettingsPlugin], [-lqml_Qt_labs_settings_qmlsettingsplugin])
diff --git a/src/qml/bitcoin.cpp b/src/qml/bitcoin.cpp
index 55a1e152d..288a88b42 100644
--- a/src/qml/bitcoin.cpp
+++ b/src/qml/bitcoin.cpp
@@ -52,9 +52,7 @@ QT_END_NAMESPACE
Q_IMPORT_PLUGIN(QtQmlPlugin)
Q_IMPORT_PLUGIN(QtQmlModelsPlugin)
Q_IMPORT_PLUGIN(QtQuick2DialogsPlugin)
-#ifndef QT_QPA_PLATFORM_ANDROID
Q_IMPORT_PLUGIN(QtQuick2DialogsPrivatePlugin)
-#endif
Q_IMPORT_PLUGIN(QtQuick2Plugin)
Q_IMPORT_PLUGIN(QtQuick2WindowPlugin)
Q_IMPORT_PLUGIN(QtQuickControls1Plugin)? |
|
Need rebase. When undraft? :) |
jarolrod
force-pushed
the
custom-data-dir
branch
from
802649e to
89ca089
Compare
|
rebased over main |
Merged
hebasto
added a commit
that referenced
this pull request
Jun 8, 2024
7a8fb19 qml: UI only display datadir functionality (D33r-Gee) b648cbb qml: added getting custom datadir for display (D33r-Gee) Pull request description: This pull request builds upon #392 and introduces enhancements to display the data directory information within the UI. This functionality encompasses both default and custom data directory paths, fulfilling the UI requirements for user-defined data directory selection initiated in #273. Also the custom datadir is not persistent at the moment it will be once the back end wiring is added. <details> <summary>Ubuntu 22.04 Screenshots</summary>  </details> <details> <summary>Android Screenshots</summary>  </details> As a potential follow-up enhancement, consider incorporating mechanisms for saving the data directory path. This could be achieved through: - Double-click functionality: Allow users to save the displayed path by simply double-clicking on it. This provides a convenient and intuitive method for desktop environments. - Dedicated button: For mobile use cases or scenarios where double-clicking might not be feasible, introduce a dedicated "Save Path" button. This ensures a clear and accessible action for users on various devices. ACKs for top commit: GBKS: ACK 7a8fb19. Looks and feels great, just tested again on MacOS. MarnixCroes: tACK 7a8fb19 on Ubuntu desktop pablomartin4btc: reACK 7a8fb19 Tree-SHA512: 4be20832b72fee99046e78ce45e766ff3f00fc556d57c47311828daa3270d1980fdb2b16b95715024a5835f5730f4a3a347337e9dcc22f57fbaf2ac6711a9f6d
|
replaced by #408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened to showcase initial support. Lacks system settings wiring.