Merge #440: wallet, tests: Avoid stringop-overflow warning in Pollute…

…PubKey

62468fe wallet, tests: Avoid stringop-overflow warning in PollutePubKey (Ava Chow)

Pull request description:

  This PR backports bitcoin/bitcoin#30131 to enhance the build experience with GCC 14.

ACKs for top commit:
  jarolrod:
    ACK 62468fe

Tree-SHA512: ff934217791cc99d2d08976bd7f2f4f980910f69cbd955fdd3e82ea6fb3d03e94fdb2a526584012c9a11124ba91dd5820ec7a942a599205e00f38f674a9c3586

src/wallet/test/wallet_tests.cpp

@@ -498,8 +498,10 @@ static void TestWatchOnlyPubKey(LegacyScriptPubKeyMan* spk_man, const CPubKey& a
 // Cryptographically invalidate a PubKey whilst keeping length and first byte
 static void PollutePubKey(CPubKey& pubkey)
 {
-    std::vector<unsigned char> pubkey_raw(pubkey.begin(), pubkey.end());
-    std::fill(pubkey_raw.begin()+1, pubkey_raw.end(), 0);
+    assert(pubkey.size() >= 1);
+    std::vector<unsigned char> pubkey_raw;
+    pubkey_raw.push_back(pubkey[0]);
+    pubkey_raw.insert(pubkey_raw.end(), pubkey.size() - 1, 0);
     pubkey = CPubKey(pubkey_raw);
     assert(!pubkey.IsFullyValid());
     assert(pubkey.IsValid());