[DO NOT MERGE] Diff with remote #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for applied objects to become healthy using CEL readiness rule or kstatus
Also refactor to demonstrate where the 35 minute pause comes from.
…ulemock mocks: Update ComputeForwardingRule mock responses with API default fields
Signed-off-by: Alex Pana <[email protected]>
- verify gomod - verify go imports
More github actions for Compositions
…og-dep tests: log resource name for dependency failure
It would be nice, but it does introduce a circular dependency that go.mod can't figure out.
…or_bigtabletable tests: improve fidelity for BigtableTable
…xtemplatejob_controller feat: create direct controller for DataflowFlexTemplateJob
Starting with the services we definitely need!
…ic-test-scifi-issues Fix dynamic test scifi issues
…eriodics fix: Rename sqlinstance test fixtures to not end in "basic"
…b-scifi Use gkehub direct controller for presubmits
Some of the periodic tests previously (incorrectly) relied on the legacy DCL schema for recent direct resource conversions. This fix properly handles the edge cases for each of the resource types (direct, terraform, and dcl).
MySQL requires that the host is passed-in along with the username. Otherwise, the delete request will fail.
…dics fix: Properly handle test edge cases direct resource conversions
…install Compositions: Fix manual install version
This avoids another copy of the direct-reconciler list, with the accompanying possibilities for skew.
LROs (and things like LROs) are timing dependent, so we remove them from LROs.
…iceattachment MockGCP: Support for ComputeServiceAttachment
This issue was never hit before because testNoChangeAfterUpdate is currently only enabled for SQLInstances resources. We recently added a SQLInstance test case that does not set an update.yaml resource (sqlinstance-clone-minimal), and it revealed the problem causing a nil pointer dereference when getting update object.
…a_events tests: refactor to share code for removing extra events
…eID_immutable tool: mark resourceID as immutable field in template
…mpare_mock_to_use_run_e2e refactor: have compare-mock call into run-e2e
…services tests: enable some services in e2e
…-user-deletion fix: Delete mysql root user after creation
…e/google.golang.org-genproto-digest fix(deps): update google.golang.org/genproto digest to 8af14fe
…dics-part-2 fix: Skip testNoChangeAfterUpdate if update resource is empty. Samples test failure is unrelated and being investigated.
From Go docs: https://go.dev/ref/mod#go-work-file > It is generally inadvisable to commit go.work files into version control systems
fix: Add go.work.sum to gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.