Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for sqlalchemy 1.3 #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for sqlalchemy 1.3 #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions flask_potion/contrib/alchemy/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,18 @@ def relation_add(self, item, attribute, target_resource, target_item):
def relation_remove(self, item, attribute, target_resource, target_item):
before_remove_from_relation.send(self.resource, item=item, attribute=attribute, child=target_item)
try:
getattr(item, attribute).remove(target_item)
after_remove_from_relation.send(self.resource, item=item, attribute=attribute, child=target_item)
collection = getattr(item, attribute)
except ValueError:
pass # if the relation does not exist, do nothing
else:
if target_item in collection:
collection.remove(target_item)
after_remove_from_relation.send(
self.resource,
item=item,
attribute=attribute,
child=target_item,
)

def commit(self):
session = self._get_session()
Expand Down