Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a logical error deciding whether to return a patchable schema. #153

Merged

Conversation

bjornt
Copy link
Contributor

@bjornt bjornt commented Nov 20, 2018

This partly fixes issue #98, where a field that has io="cr" wouldn't
show up in the "create" schema.

This partly fixes issue biosustain#98, where a field that has io="cr" wouldn't
show up in the "create" schema.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.08% when pulling dcec4bb on bjornt:patchable-schema-logical-error into 20fb764 on biosustain:master.

@albertodonato
Copy link
Contributor

@lyschoening any chance this could be merged? potion-client won't work correctly in similar cases otherwise

@lyschoening
Copy link
Contributor

@albertodonato Sorry, been falling behind on following the PRs. Merging now.

@lyschoening lyschoening merged commit c56df5b into biosustain:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants