feat: improve alignment for output directories (i.e. not pre-create t…

…hem) between test conditions and runBioSimulations
biosimulators · Feb 11, 2022 · b12c389 · b12c389
1 parent 34c9d4b
commit b12c389
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/biosimulators_test_suite/test_case/published_project.py b/biosimulators_test_suite/test_case/published_project.py
@@ -320,9 +320,6 @@ def eval(self, specifications, working_dirname, synthetic_archives_dir=None, dry
         if dry_run:
             return
 
-        if not os.path.isdir(working_dirname):
-            os.makedirs(working_dirname)
-
         # pull image and execute COMBINE/OMEX archive for case
         try:
             self.exec_sedml_docs_in_archive(specifications, working_dirname, cli=cli)

diff --git a/tests/test_case/test_published_project.py b/tests/test_case/test_published_project.py
@@ -218,6 +218,9 @@ def exec_archive(error, missing_report, extra_report, missing_data_set, extra_da
                 data[0][0] = -1
                 data[1][0] = -1
 
+            if not os.path.isdir(out_dir):
+                os.makedirs(out_dir)
+
             if extra_report:
                 report = Report(id='report', data_sets=[DataSet(id=i, label=l) for i, l in zip(ids, labels)])
                 data_set_results = DataSetResults({i: d for i, d in zip(ids, data)})
@@ -229,6 +232,7 @@ def exec_archive(error, missing_report, extra_report, missing_data_set, extra_da
                 ReportWriter().run(report, data_set_results, out_dir, 'BIOMD0000000912_sim.sedml/report', ReportFormat.h5)
 
             plot_file = os.path.join(out_dir, 'plot.pdf')
+
             with open(plot_file, 'w'):
                 pass