Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest possible roadrunner, and fix some bugs. #6

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

luciansmith
Copy link
Contributor

SBML elements that don't start with "M_" are now allowed (!)

MassPy seems to assume that metabolite IDs start with "M_" and that reaction IDs start with "R_"... but doesn't *require* them to.  But it'll strip those parts of the IDs if left unprompted.  But the wrapper was assuming that every ID originally had those characters, and was stripping them back off afterwards.  This change lets both be true.  (And adds a new omex test that doesn't have those characters in the IDs.)
Since the sbml ids can have two forms, the index might be off.  Also, fix the name of the test file.
@luciansmith luciansmith merged commit ce6f19f into dev Oct 29, 2024
1 of 3 checks passed
@luciansmith luciansmith deleted the earlier-rr branch October 29, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant