refactor: expose ProjectLayout as service #4851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds upon #4846, but takes things one step further: It puts the
ProjectLayout
into its own crate (biome_project_layout
) and exposes it as a service.ManifestServices
still exists, but can now be extracted on-demand for the right file path. This approach should help with future maintainability, because it will make it easier to extract other information from theProjectLayout
, such asTsConfigJson
.I have also updated
biome_analyze
to work withUtf8Path
instead ofstd::path::Path
, since these paths are also used for service extraction now.Functionally, nothing should have changed except for improved diagnostics with
noUndeclaredDependencies
.Test Plan
CI should remain green.
I have also enabled
noUndeclaredDependencies
in our ownbiome.json
so we get to dogfood the rule ourselves going forward (I even discovered one unlisted dependency in the benchmarks).