Fixes bad codegen in gcc 11.3 #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 34 34
Lines 11325 11325
=======================================
Hits 11022 11022
Misses 303 303 ☔ View full report in Codecov by Sentry. |
biojppm
force-pushed
the
fix/486_ub_gcc11
branch
2 times, most recently
from
72acea3 to
bd83037
Compare
biojppm
force-pushed
the
fix/486_ub_gcc11
branch
from
5803002 to
3140b57
Compare
biojppm
force-pushed
the
fix/486_ub_gcc11
branch
from
b0f0165 to
d216194
Compare
no luck so far with any of the following: native gcc11.4 on ubuntu22.04: ``` ( \ set -xe ; \ cd /rapidyaml/ ; \ bt=Release ; \ bd=build/docker-$bt ; \ tgt=ryml-test-scalar_dquoted ; \ export C4_EXTERN_DIR=`pwd`/build/extern ; \ mkdir -p $C4_EXTERN_DIR ; \ cmake -B $bd -D RYML_DEV=ON -D RYML_BUILD_BENCHMARKS=OFF && \ cmake --build $bd -j --target $tgt && \ ./$bd/test/$tgt --gtest_filter=*486* ) ``` Tried also using -DRYML_STRICT_ALIASING=OFF (to remove -fstrict-aliasing) and -DRYML_PEDANTIC=OFF, and still could not reproduce. with wine in arch linux (gcc 14): ``` ( set -xe ; \ bt=Release ; \ bd=build/mingw-$bt ; \ tgt=ryml-test-scalar_dquoted ; \ cd ~/proj/rapidyaml/ ; \ cmake -B $bd -D CMAKE_TOOLCHAIN_FILE=`pwd`/.github/mingw-w64-x86_64.cmake -D RYML_DEV=ON && \ cmake --build $bd -j --target $tgt && \ env WINEPATH=/usr/x86_64-w64-mingw32/bin wine ./$bd/bin/$tgt.exe --gtest_filter=*486* ) ``` with wine in ubuntu18.04 (gcc 7.3) ``` ( set -xe ; \ cd /rapidyaml/ ; \ bt=Release ; \ bd=build/docker-mingw-$bt ; \ tgt=ryml-test-scalar_dquoted ; \ export C4_EXTERN_DIR=`pwd`/build/extern ; \ mkdir -p $C4_EXTERN_DIR ; \ cmake -B $bd -D CMAKE_TOOLCHAIN_FILE=`pwd`/.github/mingw-w64-x86_64.cmake -D RYML_DEV=ON -D RYML_BUILD_BENCHMARKS=OFF && \ cmake --build $bd -j --target $tgt && \ env WINEPATH="/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32;/usr/x86_64-w64-mingw32/lib" wine ./$bd/bin/$tgt.exe --gtest_filter=*486* ) ``` with wine in ubuntu22.04 (gcc 10) ``` ( set -xe ; \ cd /rapidyaml/ ; \ bt=Release ; \ bd=build/docker-mingw-$bt ; \ tgt=ryml-test-scalar_dquoted ; \ export C4_EXTERN_DIR=`pwd`/build/extern ; \ mkdir -p $C4_EXTERN_DIR ; \ cmake -B $bd -D CMAKE_TOOLCHAIN_FILE=`pwd`/.github/mingw-w64-x86_64.cmake -D RYML_DEV=ON -D RYML_BUILD_BENCHMARKS=OFF && \ cmake --build $bd -j --target $tgt && \ env WINEPATH="/usr/lib/gcc/x86_64-w64-mingw32/10-win32;/usr/x86_64-w64-mingw32/lib" wine ./$bd/bin/$tgt.exe --gtest_filter=*486* ) ```
biojppm
force-pushed
the
fix/486_ub_gcc11
branch
2 times, most recently
from
1b3b0c3 to
2fcd2d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486
See also #464