Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to bulk #37

Merged
merged 6 commits into from
Jan 8, 2025
Merged

updates to bulk #37

merged 6 commits into from
Jan 8, 2025

Conversation

daler
Copy link
Member

@daler daler commented Jan 4, 2025

In an effort to make it a little easier each time around, here's a round of updates to the bulk page.

@daler daler changed the title Bioconductor updates updates to bulk Jan 4, 2025
@daler daler requested a review from aliciaaevans January 5, 2025 01:20
Copy link
Contributor

@aliciaaevans aliciaaevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions, but it looks great.

source/developer/bulk.rst Outdated Show resolved Hide resolved
source/developer/bulk.rst Show resolved Hide resolved
source/developer/bulk.rst Outdated Show resolved Hide resolved
source/developer/bulk.rst Outdated Show resolved Hide resolved
source/developer/bulk.rst Outdated Show resolved Hide resolved
source/developer/bulk.rst Outdated Show resolved Hide resolved
source/developer/bulk.rst Outdated Show resolved Hide resolved
source/developer/bulk.rst Show resolved Hide resolved
source/developer/bulk.rst Outdated Show resolved Hide resolved
@daler
Copy link
Member Author

daler commented Jan 6, 2025

Great comments, thanks. All are addressed (or applied directly from suggestions). I'll leave this open until we finish the final merge, in case there's still something we're missing.

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @daler!

@bgruening bgruening merged commit db36560 into main Jan 8, 2025
2 checks passed
@bgruening bgruening deleted the bioconductor-updates branch January 8, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants