Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

[WIP] Add support for new <Props> syntax in React classes #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kangax
Copy link

@kangax kangax commented Sep 6, 2018

No description provided.

@kangax kangax changed the title Add support for new <Props> syntax in React classes [WIP] Add support for new <Props> syntax in React classes Sep 6, 2018
@kangax
Copy link
Author

kangax commented Sep 6, 2018

Just need to add support for constructor(props: Props)

@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #23 into master will decrease coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   74.45%   74.05%   -0.41%     
==========================================
  Files          11       11              
  Lines         321      316       -5     
  Branches       97       96       -1     
==========================================
- Hits          239      234       -5     
  Misses         82       82
Impacted Files Coverage Δ
src/transformers/es6Classes.js 100% <100%> (ø) ⬆️
src/helpers/annotateConstructor.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 632e3dc...0baf66f. Read the comment docs.

@kevinbarabash
Copy link

Does this handle lifecycle methods that take props?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants