Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Einstein Telescope geometry with LAL #894

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

milanwils
Copy link

Problem
As mentioned in #713, the current geometry of the ET is not in line with its definition in LAL.

  1. The labels of ET2 and ET3 are swapped.
  2. Currently the new corner points are calculated by updating the latitude and longitude approximately and not updating the elevation. Additionally, the azimuth and tilt do not take into account the curvature of the earth. This leads to small differences in the vertex position and unit vector. As a result, the null stream is not accurate and signal leaks into it.

Proposed Solution

  1. This is addressed in this PR by adding an optional clockwise option to the detector config. I set the value in the ET.interferometer file to clockwise=False so that the default is consistent with LAL. If this is undesired for backwards compatibility, it could be set to clockwise=True .
  2. This issue is addressed by following the same specification as LAL: T1400308. The code is rather verbose to avoid confusion but can be changed if denser code is preferred. This algorithm required the implementation of a transform from WGS84 coordinated to ECEF coordinates. I added a small test to check the consistency with the forward transformation. In the implementation of this transform I used uninformative variable names to be consistent with the reference (they do not have a physical meaning anyway).

Additional information
There is also a small error in the LAL config, see LAL PR2399. Only if both get accepted do the configurations become identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants