Align Einstein Telescope geometry with LAL #894
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As mentioned in #713, the current geometry of the ET is not in line with its definition in LAL.
Proposed Solution
ET.interferometer
file toclockwise=False
so that the default is consistent with LAL. If this is undesired for backwards compatibility, it could be set toclockwise=True
.Additional information
There is also a small error in the LAL config, see LAL PR. Only if both get accepted do the configurations become identical.