Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: fix style error #892

Merged
merged 2 commits into from
Jan 9, 2025
Merged

STY: fix style error #892

merged 2 commits into from
Jan 9, 2025

Conversation

mj-will
Copy link
Collaborator

@mj-will mj-will commented Jan 9, 2025

Ignore the specific error relating to missing whitespace (E226) in the logging out for bilby_MCMC.

Motivation

After an update to various dependencies, f"Temp:{ii}<->{ii+1}|" was trigger a flake8 error (226) because of missing whitespace around the operator(s) (not sure if it's a specific operator or all of them). Since these operators are actually just part of the logging statement, this error can be ignored.

Colm pointed out the issue was the i+1 rather than the string.

See e.g. the CI here: https://github.com/bilby-dev/bilby/actions/runs/12686391271/job/35358629525

Changes

Fix the fomatting issue,

Other details

Closes #889

bilby/bilby_mcmc/sampler.py Outdated Show resolved Hide resolved
mj-will and others added 2 commits January 9, 2025 17:37
Ignore the specific error relating to missing whitespace (E226)
Co-authored-by: Colm Talbot <[email protected]>
@mj-will mj-will changed the title STY: ignore flake8 error in logging string STY: fix style error Jan 9, 2025
@mj-will mj-will added this to the 2.5.0 milestone Jan 9, 2025
@ColmTalbot ColmTalbot merged commit 1804456 into bilby-dev:main Jan 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pre-commit CI
3 participants