Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Update the resume file check to see if the file is empty #890

Merged
merged 1 commit into from
Jan 10, 2025
Merged

BUG: Update the resume file check to see if the file is empty #890

merged 1 commit into from
Jan 10, 2025

Conversation

GregoryAshton
Copy link
Collaborator

Resolves #43 by adding a check to see if the file is empty

@GregoryAshton GregoryAshton linked an issue Jan 8, 2025 that may be closed by this pull request
Confusing message on reading empty resume files #43
Closed
@GregoryAshton GregoryAshton changed the title Update the resume file check to see if the file is empty BUG: Update the resume file check to see if the file is empty Jan 8, 2025
@ColmTalbot ColmTalbot force-pushed the 43-confusing-message-on-reading-empty-resume-files branch from ec6f24a to e82241d Compare January 9, 2025 17:12
adivijaykumar
adivijaykumar approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@adivijaykumar adivijaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we just need the file size and nothing else, I think we could just use os.path.getsize(self.resume_file), but I think this works as well!

@mj-will mj-will added the bug Something isn't working label Jan 10, 2025
@ColmTalbot ColmTalbot merged commit 36470d5 into main Jan 10, 2025
12 checks passed
@mj-will mj-will deleted the 43-confusing-message-on-reading-empty-resume-files branch January 13, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColmTalbot ColmTalbot ColmTalbot approved these changes

@adivijaykumar adivijaykumar adivijaykumar approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing message on reading empty resume files
4 participants
@GregoryAshton @adivijaykumar @ColmTalbot @mj-will