Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check moov atom position #1056

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Check moov atom position #1056

wants to merge 12 commits into from

Conversation

lehecht
Copy link
Contributor

@lehecht lehecht commented Jan 21, 2025

Add check to validate moov atom position and show error message.

Closes #983.

@lehecht lehecht changed the title Moov atom bug Check moov atom position Jan 21, 2025
@lehecht lehecht requested a review from mzur January 21, 2025 12:45
@@ -20,6 +20,10 @@
<span v-if="hasTooLargeError">
The video file is too large.
</span>
<span v-if="hasMoovAtomError">
The video's moov atom position is invalid.<br>
See biigle.de/manual/tutorials/videos/fixing-invalid-moov-atom
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be a dynamic link. Use the url() helper.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file used anywhere?

<b>Linux or MacOS</b>
<ol>
<li>Open terminal</li>
<li>Install: <kbd>sudo apt-get install ffmpeg</kbd></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Ubuntu-specific.

Suggested change
<li>Install: <kbd>sudo apt-get install ffmpeg</kbd></li>

<p>
<b>Windows</b>
<ol>
<li>Install FFMPEG</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is also mentioned at the top.

Suggested change
<li>Install FFMPEG</li>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use <code> elements instead of <kbd> (these are meant for keyboard keys).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should call this article "Fix video encoding". Then we can add more sections later (e.g. converting to H.264, fixing a video with multiple mdat, ...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MP4 moov atom validation
2 participants