Add screenshot button to video annotator

[lehecht]

Closes #956.

[lehecht]

@mzur
How can I check if my button is disabled for non-CORS enabled videos? Do you know any websites with non-CORS enabled videos that I could use to test this? Or did you use a different approach for testing?

[mzur]

On your local instance you could use the BIIGLE landing page video.

[mzur]

I think I prefer not to use provide/inject here as it hides where the data is coming from. Maybe this is a chance to refactor the screenshot button a bit so it gets all data it needs through props. E.g. if it gets the image/video ID as a prop, it does not even need the image/video changed event any more.

The map.init event must stay, though, as the map object must not be passed as a prop. It should never be made reactive.

[lehecht]

@mzur

Maybe this is a chance to refactor the screenshot button a bit so it gets all data it needs through props

I also thought about it, but then I would need to refactor the video and image settingsTab, too. The settingsTabs import the screenshotButton, which would then need the same properties as the screenshotbutton. I am not sure, if they should get props that they will not use except to pass them to the screenshotbutton.

[mzur]

If it's not too much, I think it is fine to pass the props through the settings tab.

Alternatively you could provide the individual properties (e.g. current ID, current filename) instead of a single "files" object. This is at least more descriptive and you can find the location where these are coming from easier than with the generic name. This would still be better than the solution with the event.

[mzur]

Thanks!