-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check moov atom position #1056
base: master
Are you sure you want to change the base?
Check moov atom position #1056
Conversation
@@ -20,6 +20,10 @@ | |||
<span v-if="hasTooLargeError"> | |||
The video file is too large. | |||
</span> | |||
<span v-if="hasMoovAtomError"> | |||
The video's moov atom position is invalid.<br> | |||
See biigle.de/manual/tutorials/videos/fixing-invalid-moov-atom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must be a dynamic link. Use the url()
helper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file used anywhere?
<b>Linux or MacOS</b> | ||
<ol> | ||
<li>Open terminal</li> | ||
<li>Install: <kbd>sudo apt-get install ffmpeg</kbd></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Ubuntu-specific.
<li>Install: <kbd>sudo apt-get install ffmpeg</kbd></li> |
<p> | ||
<b>Windows</b> | ||
<ol> | ||
<li>Install FFMPEG</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is also mentioned at the top.
<li>Install FFMPEG</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use <code>
elements instead of <kbd>
(these are meant for keyboard keys).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should call this article "Fix video encoding". Then we can add more sections later (e.g. converting to H.264, fixing a video with multiple mdat
, ...).
Add check to validate moov atom position and show error message.
Closes #983.