Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Feature/timeline #136

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Feature/timeline #136

wants to merge 8 commits into from

Conversation

con322
Copy link
Contributor

@con322 con322 commented Feb 13, 2019

Proposed Changes

  • New timeline block, allows user to add milestones with inputs for heading (above the timeline line), title and content.

Resolves #128

Copy link
Member

@jaymcp jaymcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works really nicely; great work!
One thing, though, is that the front-end breaks if JavaScript is disabled/not available. I'd suggest adjusting the layout in CSS with a sensible fallback if the .no-js class is present.

@con322
Copy link
Contributor Author

con322 commented Feb 13, 2019

no-js-timeline

If there's no js the timeline milestones will be stacked so that they are all visible at once due to scroll functionality being disabled when js is disabled.

Copy link
Member

@jaymcp jaymcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaymcp jaymcp added this to the v1.2.0 milestone Feb 20, 2019
@jaymcp jaymcp added the enhancement New feature or request label Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants