FIX: Use intersection to find existing events.json files #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 83.56% // Head: 83.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1574 +/- ##
==========================================
- Coverage 83.56% 83.37% -0.19%
==========================================
Files 91 91
Lines 3736 3736
Branches 1141 1141
==========================================
- Hits 3122 3115 -7
- Misses 518 525 +7
Partials 96 96
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
effigies
commented
Dec 28, 2022
| @@ -355,9 +355,8 @@ describe('Events', function () { | |||
| jsonFiles, | |||
| '', | |||
| ).then((issues) => { | |||
| assert.strictEqual(issues.length, 2) | |||
| assert.strictEqual(issues.length, 1) | |||
There was a problem hiding this comment.
Looking at this test, I couldn't see why this used to be 2. Seems like it could have been a meaningless duplicate, so this fix seems sensible, but would want confirmation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves HED failure reported in #1573.