Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename argument mata-var in download help CLI #88

Open
jjjermiah opened this issue Dec 13, 2024 · 1 comment
Open

fix: Rename argument mata-var in download help CLI #88

jjjermiah opened this issue Dec 13, 2024 · 1 comment

Comments

@jjjermiah
Copy link
Contributor

          Looks great! And super easy to use. 

I think the only thing that could be improved is actually in the orcestra-datasets level, so I'll leave an issue there about it. But the help for the download function looks like

% readii-datasets radiomicsets download -h
Usage: readii-datasets radiomicsets download [OPTIONS] [NAME OF DATASET]

  Download a file for this dataset.

and then the table has these headings:

% readii-datasets radiomicsets table
                                      Radiomicsets                                       
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Name                             ┃ Dataset Name            ┃ Date Created ┃ Datatypes ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ HNSCC_Features                   │ HNSCC                   │ 2024-11-20   │ radiomics │
│ RADCURE_Features                 │ RADCURE                 │ 2024-11-20   │ radiomics │
│ HEAD-NECK-RADIOMICS-HN1_Features │ HEAD-NECK-RADIOMICS-HN1 │ 2024-11-20   │ radiomics │
└──────────────────────────────────┴─────────────────────────┴──────────────┴───────────┘

so it's not immediately clear what [NAME OF DATASET] is referring to.

Originally posted by @strixy16 in #80 (review)

@jjjermiah
Copy link
Contributor Author

all thats needed is to pin orcestra-downloader minimum version to 0.11 with the new fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant