Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing wrong with getSegmentationType and hasnt caused any issues (i think) #54

Open
jjjermiah opened this issue Oct 31, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jjjermiah
Copy link
Contributor

jjjermiah commented Oct 31, 2024

just wondering whatre the odds that the csv file might have
both 'RTSTRUCT' AND 'SEG' in modality column, and maybe we could check for that and throw an error?

Projects:

https://github.com/bhklab/readii/blob/eaeb904eb42c8abb1bef02e9d2921a8d8f503648/src/readii/metadata.py#L210-L256

@strixy16
Copy link
Collaborator

strixy16 commented Nov 1, 2024

It technically is a possibility. I implemented this function so that we don't have to pass the modality in as an argument and wondered about this instance too at the time.

We could reimplement the option to set which modality to use and if it's not supplied we extract it automatically. Then if this function fails, we tell the user to set the modality when running the command.

In the orcestra pipeline it shouldn't be an issue because it's setup to specifically download RTSTRUCTS.

@strixy16 strixy16 changed the title Nothing wrong with this function and hasnt caused any issues (i think) Nothing wrong with getSegmentationType and hasnt caused any issues (i think) Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants