Geocoding with Rails Admin Map Field #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 22, 2012 17:59
parenthesis trying strings instead trying without globals? fix geocoder and bump version number
updating readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
I have modified your map field plugin for Rails Admin to geocode a lat/lng pair on the fly based on address fields. I also fixed some things which weren't working for me in the Ruby module -- the longitude parameter was not being passed through to the template at all. It appeared to be a global issue, but it's working now on my end.
I admit, this does change the functionality compared to your version, so let me know how you'd like to proceed since I think really is useful, especially for applications with heavy maps integration (like the one I'm working on..).
I noticed your note on rebasing inconsequential commits on a previous fork, and have attempted to clean up my commits preemptively.
Best wishes and thanks for writing this,
Jules Laplace