Autohost to generic bots #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekingfrog
force-pushed
the
autohost-to-generic-bots
branch
3 times, most recently
from
7f53263 to
23bac28
Compare
It is enough to block the creation of code since you must get a one to get a token.
Now that we are going to have more than one total scope, we need logic to avoid permission bypass.
Although the concept of autohost remains, the general handling of bots with regards to credentials shouldn't be tied to autohosts. This enable having bots to access the API using bearer token in a unified way. This rather massive change is mostly only a search and replace `s/autohost/bot/`. Some things are staying as they are: * `Teiserver.Autohost` remains because it's used for tachyon and matchmaking * the table `oauth_tokens` still has a column `autohost_id`, the migration will be done in a later commit. Migrations can be tricky and keeping these changes to their own commits is safer.
This completes the renaming from autohost to bot
all unused imports
geekingfrog
force-pushed
the
autohost-to-generic-bots
branch
from
32d006f to
9f777ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a big refactoring PR, tidying up some lose ends around OAuth.
The main changes are:
The next part coming will be to modify the api endpoints to accept authentication with bearer token, and create an endpoint so that a bot with the correct scope can update the map data in teiserver.