Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uncertainty to player page #552

Merged

Conversation

jauggy
Copy link
Member

@jauggy jauggy commented Dec 31, 2024

Feature

Removed units produced column (because useless)
Instead added uncertainty column. This is the prematch value.

Screenshot 2025-01-01 083354

@jauggy jauggy marked this pull request as ready for review December 31, 2024 21:41
@L-e-x-o-n
Copy link
Collaborator

Can you put this on the left side, after the team column and if possible sort players by rating (after sorting by team)?

@jauggy
Copy link
Member Author

jauggy commented Jan 3, 2025

Yeah sure will do. I just realised I could probably add num_matches too. So you know if someone is nooby or not.

@jauggy
Copy link
Member Author

jauggy commented Jan 8, 2025

Screenshot 2025-01-08 at 11 04 00 am
Added also num_matches. This will show the number of matches you played prior to this match (to be consistent with rating and uncertainty which is prematch). This allows players to understand the balance more since new players will be treated special by the balancer. If you have more than 1000 matches it is obfuscated and just shows >1000.

Old matches won't have this value, but I tested by manually adjusting teiserver_game_rating_logs value column e.g.

{"skill": 21.948025791764863, "num_matches": 123, "uncertainty": 5.09997450626287, "rating_value": 16.84805128550199, "skill_change": -1.0064758196425458, "uncertainty_change": -0.06046185070328658, "rating_value_change": -0.9460139689392584}

@L-e-x-o-n
Copy link
Collaborator

Screenshot 2025-01-08 at 11 04 00 am Added also num_matches. This will show the number of matches you played prior to this match (to be consistent with rating and uncertainty which is prematch). This allows players to understand the balance more since new players will be treated special by the balancer. If you have more than 1000 matches it is obfuscated and just shows >1000.

Old matches won't have this value, but I tested by manually adjusting teiserver_game_rating_logs value column e.g.

{"skill": 21.948025791764863, "num_matches": 123, "uncertainty": 5.09997450626287, "rating_value": 16.84805128550199, "skill_change": -1.0064758196425458, "uncertainty_change": -0.06046185070328658, "rating_value_change": -0.9460139689392584}

What is the reasoning behind obfuscating the number if the user has more than 1000 matches, I think people would still want to know it and I can't think of any disadvantages?

@jauggy
Copy link
Member Author

jauggy commented Jan 8, 2025

I'm happy to show the number. Can reuse the normalise function Teifion made which will use "K" when it gets above 1000. He uses this function for the damage values. Will update.

@jauggy
Copy link
Member Author

jauggy commented Jan 8, 2025

Updated.

Screenshot 2025-01-08 at 12 46 31 pm
Using Teifion's normalize function it looks like this.

@L-e-x-o-n L-e-x-o-n merged commit a680873 into beyond-all-reason:master Jan 9, 2025
3 checks passed
@L-e-x-o-n
Copy link
Collaborator

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants