design mode

beto-rodriguez · Aug 20, 2021 · 976ff1d · 976ff1d
1 parent 5327529
commit 976ff1d
Show file tree

Hide file tree

Showing 18 changed files with 54 additions and 12 deletions.
diff --git a/src/LiveChartsCore/CartesianChart.cs b/src/LiveChartsCore/CartesianChart.cs
@@ -144,6 +144,8 @@ public CartesianChart(
         /// <inheritdoc cref="IChart.Update(ChartUpdateParams?)" />
         public override void Update(ChartUpdateParams? chartUpdateParams = null)
         {
+            if (View.DesignerMode) return;
+
             chartUpdateParams ??= new ChartUpdateParams();
             if (chartUpdateParams.IsAutomaticUpdate && !View.AutoUpdateEnabled) return;
             if (!chartUpdateParams.Throttling)

diff --git a/src/LiveChartsCore/Kernel/Sketches/IChartView.cs b/src/LiveChartsCore/Kernel/Sketches/IChartView.cs
@@ -26,7 +26,6 @@
 using System;
 using System.Collections.Generic;
 using System.Drawing;
-using System.Threading.Tasks;
 
 namespace LiveChartsCore.Kernel.Sketches
 {
@@ -43,6 +42,11 @@ public interface IChartView
         /// </value>
         IChart CoreChart { get; }
 
+        /// <summary>
+        /// Gets whether the control is in designer mode.
+        /// </summary>
+        bool DesignerMode { get; }
+
         /// <summary>
         /// Sets the back color of the control.
         /// </summary>

diff --git a/src/LiveChartsCore/PieChart.cs b/src/LiveChartsCore/PieChart.cs
@@ -139,6 +139,8 @@ public override TooltipPoint[] FindPointsNearTo(PointF pointerPosition)
         /// <inheritdoc cref="IChart.Update(ChartUpdateParams?)" />
         public override void Update(ChartUpdateParams? chartUpdateParams = null)
         {
+            if (View.DesignerMode) return;
+
             chartUpdateParams ??= new ChartUpdateParams();
 
             if (chartUpdateParams.IsAutomaticUpdate && !View.AutoUpdateEnabled) return;

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp.Avalonia/CartesianChart.axaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharp.Avalonia/CartesianChart.axaml.cs
@@ -323,6 +323,9 @@ public CartesianChart()
 
         #region properties
 
+        /// <inheritdoc cref="IChartView.DesignerMode" />
+        public bool DesignerMode => Design.IsDesignMode;
+
         /// <inheritdoc cref="IChartView.CoreChart" />
         public IChart CoreChart => core ?? throw new Exception("Core not set yet.");
 

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp.Avalonia/PieChart.axaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharp.Avalonia/PieChart.axaml.cs
@@ -289,6 +289,9 @@ public PieChart()
 
         #region properties
 
+        /// <inheritdoc cref="IChartView.DesignerMode" />
+        public bool DesignerMode => Design.IsDesignMode;
+
         /// <inheritdoc cref="IChartView.CoreChart" />
         public IChart CoreChart => core ?? throw new Exception("Core not set yet.");
 

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp.WPF/Chart.cs b/src/skiasharp/LiveChartsCore.SkiaSharp.WPF/Chart.cs
@@ -35,7 +35,7 @@
 using FontStyle = System.Windows.FontStyle;
 using LiveChartsCore.Kernel.Events;
 using LiveChartsCore.Kernel.Sketches;
-using System.Threading.Tasks;
+using System.ComponentModel;
 
 namespace LiveChartsCore.SkiaSharpView.WPF
 {
@@ -289,6 +289,9 @@ protected Chart()
 
         #region properties
 
+        /// <inheritdoc cref="IChartView.DesignerMode" />
+        public bool DesignerMode => DesignerProperties.GetIsInDesignMode(this);
+
         /// <inheritdoc cref="IChartView.CoreChart" />
         public IChart CoreChart => core ?? throw new Exception("Core not set yet.");
 

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp.WinForms/CartesianChart.cs b/src/skiasharp/LiveChartsCore.SkiaSharp.WinForms/CartesianChart.cs
@@ -160,6 +160,7 @@ public DrawMarginFrame<SkiaSharpDrawingContext>? DrawMarginFrame
         public double ZoomingSpeed { get; set; } = LiveCharts.CurrentSettings.DefaultZoomSpeed;
 
         /// <inheritdoc cref="ICartesianChartView{TDrawingContext}.TooltipFindingStrategy" />
+        [DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
         public TooltipFindingStrategy TooltipFindingStrategy { get => _tooltipFindingStrategy; set { _tooltipFindingStrategy = value; OnPropertyChanged(); } }
 
         /// <summary>

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp.WinForms/Chart.cs b/src/skiasharp/LiveChartsCore.SkiaSharp.WinForms/Chart.cs
@@ -30,7 +30,6 @@
 using System.Collections.Generic;
 using System.ComponentModel;
 using System.Drawing;
-using System.Threading.Tasks;
 using System.Windows.Forms;
 
 namespace LiveChartsCore.SkiaSharpView.WinForms
@@ -136,6 +135,9 @@ protected Chart(IChartTooltip<SkiaSharpDrawingContext>? tooltip, IChartLegend<Sk
 
         #region properties
 
+        /// <inheritdoc cref="IChartView.DesignerMode" />
+        public bool DesignerMode => LicenseManager.UsageMode == LicenseUsageMode.Designtime;
+
         /// <inheritdoc cref="IChartView.CoreChart" />
         public IChart CoreChart => core ?? throw new Exception("Core not set yet.");
 
@@ -214,6 +216,7 @@ Color IChartView.BackColor
         public IChartLegend<SkiaSharpDrawingContext>? Legend => legend;
 
         /// <inheritdoc cref="IChartView.LegendPosition" />
+        [DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
         public TooltipPosition TooltipPosition { get => _tooltipPosition; set { _tooltipPosition = value; OnPropertyChanged(); } }
 
         /// <summary>

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp.WinForms/LiveChartsCore.SkiaSharpView.WinForms.csproj b/src/skiasharp/LiveChartsCore.SkiaSharp.WinForms/LiveChartsCore.SkiaSharpView.WinForms.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
+<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
 
   <PropertyGroup>
     <OutputType>WinExe</OutputType>
@@ -9,7 +9,7 @@
     <TargetFrameworks>net462;netcoreapp3.0</TargetFrameworks>
     <AssemblyName>LiveChartsCore.SkiaSharpView.WinForms</AssemblyName>
     <RootNamespace>LiveChartsCore.SkiaSharpView.WinForms</RootNamespace>
-    <Version>2.0.0-beta.50</Version>
+    <Version>2.0.0-beta.55</Version>
     <PackageIcon>icon.png</PackageIcon>
     <Description>Simple, flexible, interactive and powerful data visualization for WindowsForms.</Description>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp.Xamarin.Forms/CartesianChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharp.Xamarin.Forms/CartesianChart.xaml.cs
@@ -358,6 +358,9 @@ public CartesianChart()
 
         #region properties
 
+        /// <inheritdoc cref="IChartView.DesignerMode" />
+        public bool DesignerMode => DesignMode.IsDesignModeEnabled;
+
         /// <inheritdoc cref="IChartView.CoreChart" />
         public IChart CoreChart => core ?? throw new Exception("Core not set yet.");
 

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp.Xamarin.Forms/PieChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharp.Xamarin.Forms/PieChart.xaml.cs
@@ -32,7 +32,6 @@
 using System.Collections.Specialized;
 using System.ComponentModel;
 using System.Drawing;
-using System.Threading.Tasks;
 using Xamarin.Essentials;
 using Xamarin.Forms;
 using Xamarin.Forms.Xaml;
@@ -303,6 +302,9 @@ public PieChart()
 
         #region properties
 
+        /// <inheritdoc cref="IChartView.DesignerMode" />
+        public bool DesignerMode => DesignMode.IsDesignModeEnabled;
+
         /// <inheritdoc cref="IChartView.CoreChart" />
         public IChart CoreChart => core ?? throw new Exception("Core not set yet.");
 

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp/SKCharts/SKCartesianChart.cs b/src/skiasharp/LiveChartsCore.SkiaSharp/SKCharts/SKCartesianChart.cs
@@ -24,7 +24,6 @@
 using System.Collections.Generic;
 using System.Drawing;
 using System.IO;
-using System.Threading.Tasks;
 using LiveChartsCore.Drawing;
 using LiveChartsCore.Kernel;
 using LiveChartsCore.Kernel.Events;
@@ -76,6 +75,10 @@ public SKCartesianChart(ICartesianChartView<SkiaSharpDrawingContext> view) : thi
             PointStates = view.PointStates;
         }
 
+
+        /// <inheritdoc cref="IChartView.DesignerMode" />
+        public bool DesignerMode => false;
+
         /// <summary>
         /// Gets or sets the background.
         /// </summary>

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharp/SKCharts/SKPieChart.cs b/src/skiasharp/LiveChartsCore.SkiaSharp/SKCharts/SKPieChart.cs
@@ -73,6 +73,10 @@ public SKPieChart(IPieChartView<SkiaSharpDrawingContext> view) : this()
             Total = view.Total;
         }
 
+
+        /// <inheritdoc cref="IChartView.DesignerMode" />
+        public bool DesignerMode => false;
+
         /// <summary>
         /// Gets or sets the background.
         /// </summary>

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpVew.WinUI/CartesianChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpVew.WinUI/CartesianChart.xaml.cs
@@ -377,6 +377,9 @@ public CartesianChart()
         FrameworkElement IWinUIChart.Canvas => motionCanvas;
         FrameworkElement IWinUIChart.Legend => legend;
 
+        /// <inheritdoc cref="IChartView.DesignerMode" />
+        public bool DesignerMode => Windows.ApplicationModel.DesignMode.DesignModeEnabled;
+
         /// <inheritdoc cref="IChartView.CoreChart" />
         public IChart CoreChart => _core ?? throw new Exception("Core not set yet.");
 

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpVew.WinUI/PieChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpVew.WinUI/PieChart.xaml.cs
@@ -24,7 +24,6 @@
 using System.Collections.Generic;
 using System.Collections.Specialized;
 using System.ComponentModel;
-using System.Threading.Tasks;
 using LiveChartsCore.Drawing;
 using LiveChartsCore.Kernel;
 using LiveChartsCore.Kernel.Events;
@@ -35,8 +34,6 @@
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
 using Microsoft.UI.Xaml.Media;
-using Windows.ApplicationModel.Core;
-using Windows.UI.Core;
 using Windows.UI.Text;
 
 namespace LiveChartsCore.SkiaSharpView.WinUI
@@ -315,6 +312,9 @@ public PieChart()
         FrameworkElement IWinUIChart.Canvas => motionCanvas;
         FrameworkElement IWinUIChart.Legend => legend;
 
+        /// <inheritdoc cref="IChartView.DesignerMode" />
+        public bool DesignerMode => Windows.ApplicationModel.DesignMode.DesignModeEnabled;
+
         /// <inheritdoc cref="IChartView.CoreChart" />
         public IChart CoreChart => _core ?? throw new Exception("Core not set yet.");
 

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpView.UWP/CartesianChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpView.UWP/CartesianChart.xaml.cs
@@ -25,7 +25,6 @@
 using System.Collections.ObjectModel;
 using System.Collections.Specialized;
 using System.ComponentModel;
-using System.Threading.Tasks;
 using LiveChartsCore.Drawing;
 using LiveChartsCore.Kernel;
 using LiveChartsCore.Kernel.Events;
@@ -381,6 +380,9 @@ public CartesianChart()
         FrameworkElement IUwpChart.Canvas => motionCanvas;
         FrameworkElement IUwpChart.Legend => legend;
 
+        /// <inheritdoc cref="IChartView.DesignerMode" />
+        public bool DesignerMode => Windows.ApplicationModel.DesignMode.DesignModeEnabled;
+
         /// <inheritdoc cref="IChartView.CoreChart" />
         public IChart CoreChart => _core ?? throw new Exception("Core not set yet.");
 

diff --git a/src/skiasharp/LiveChartsCore.SkiaSharpView.UWP/PieChart.xaml.cs b/src/skiasharp/LiveChartsCore.SkiaSharpView.UWP/PieChart.xaml.cs
@@ -35,7 +35,6 @@
 using LiveChartsCore.Kernel.Events;
 using LiveChartsCore.Drawing;
 using Windows.UI.Xaml.Input;
-using System.Threading.Tasks;
 using Windows.ApplicationModel.Core;
 using Windows.UI.Core;
 
@@ -314,6 +313,9 @@ public PieChart()
         FrameworkElement IUwpChart.Canvas => motionCanvas;
         FrameworkElement IUwpChart.Legend => legend;
 
+        /// <inheritdoc cref="IChartView.DesignerMode" />
+        public bool DesignerMode => Windows.ApplicationModel.DesignMode.DesignModeEnabled;
+
         /// <inheritdoc cref="IChartView.CoreChart" />
         public IChart CoreChart => _core ?? throw new Exception("Core not set yet.");
 

diff --git a/tests/LiveChartsCore.UnitTesting/MockedObjects/TestCartesianChartView.cs b/tests/LiveChartsCore.UnitTesting/MockedObjects/TestCartesianChartView.cs
@@ -28,6 +28,8 @@ public TestCartesianChartView()
                 this, LiveChartsSkiaSharp.DefaultPlatformBuilder, CoreCanvas);
         }
 
+        public bool DesignerMode => false;
+
         IChart IChartView.CoreChart => Core;
 
         public CartesianChart<SkiaSharpDrawingContext> Core { get; }