[WIP] [Refactor] Séparer les actions PUT #update et PUT #status #5031
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Au cours de nos explorations autour de nos façons d'utiliser les params passés à
Admin::RdvsController#update
, nous avons constaté que cette action gère trop de params (définis dansrdv_update_params
). Cela nous a causé de mauvaises surprises avecagent_ids
(voir #5026).Nous avons compris qu'il était plus simple de gérer plusieurs actions sur les RDVs (mettre à jour les attributs, ajouter ou retirer des usagers, des agents, mettre à jour le statut) dans des actions séparées afin d'y appliquer des policies spécialisées.
C'est donc avec deux objectifs en tête que je propose ce changement :
#update
en lui retirant les traitements spécifiques au changement destatus