ajout de pry et support DEBUG pour les feature specs js [skip-ci] #5001
+25
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francois-ferrandis
approved these changes
Feb 3, 2025
| ) | ||
| # these args seem to reduce test flakyness | ||
| args = %w[no-sandbox disable-gpu disable-dev-shm-usage window-size=1500,1000 disable-search-engine-choice-screen] | ||
| args.prepend("headless") unless ENV["DEBUG"] |
There was a problem hiding this comment.
Je suggère d'utiliser un nom de variable plus spécifique, comme ça quand on le cherche dans le repo, on tombe à la fois sur ce code et sur la doc !
Je peux proposer NO_HEADLESS ou DISABLE_HEADLESS ou alors SHOW_CHROME_WINDOW, ou autre bien sûr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dans cette PR je partage une manière de debugger les feature specs E2E que j’apprécie - et qui est sûrement améliorable !
debug-pry.2025-01-22T08.27.01Z.webm