Améliorer le message d'erreur sur les horaires de plage / indisponibilité #4976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francois-ferrandis
changed the title
|
@victormours J'ai initialement tenté de factoriser dans |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexte
Dans le cadre du trio sur le formulaire des plages d'ouverture (@francois-ferrandis @Teodora-Stanki @mekaidmekaid) nous souhaitons améliorer le message d'erreur affiché lorsqu'on saisit une date de fin qui n'est pas ultérieure à la date de début.
Message actuel :
Formulation proposée :
Solution
J'ai initialement tenté de factoriser dans
RecurrenceConcern, mais j'ai découvert des bugs (corrigés dans #4983), donc là je reste minimal dans cette PR.Avant
Après