Skip to content

Commit

Permalink
Merge pull request #1165 from betagouv/fix/export-pdf-error-when-no-a…
Browse files Browse the repository at this point in the history
…nalysis

fix: PDF export error when no measuring point objectgroup or standard
  • Loading branch information
wiwski authored Dec 4, 2024
2 parents b7a3203 + e1527c9 commit 0fae585
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lab_notebook/pdf_export/pdf.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ def generate_measuring_points_story( # pylint: disable=too-many-locals
styles["Normal"],
)
)
cols.append(left_col)
cols.append(left_col)

if measuring_point["name"] in measuring_point_images:
img = generate_image_with_points(
Expand Down
6 changes: 6 additions & 0 deletions lab_notebook/tests/pdf_export/test_pdf.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,12 @@ def test_generate_measuring_points_story():
"object_group": None,
"standard": {"label": "standard test 2"},
},
{
"name": "point-test-3",
"comments": "test comment 2",
"object_group": None,
"standard": None,
},
]
notebook_images = [
{
Expand Down

0 comments on commit 0fae585

Please sign in to comment.