BFE-300: Update Pools Banner #322
Conversation
…een width + draw copy on top vs embedding in the banner
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
| src={`${cloudinaryUrl}/station/pools-bg.png`} | ||
| alt="Pools Banner" | ||
| layout="responsive" | ||
| width={1200} | ||
| height={600} | ||
| className="h-auto w-full object-cover" | ||
| className="z-0" |
There was a problem hiding this comment.
Please use fill instead height and width and set the ratio
There was a problem hiding this comment.
unfortunately this will throw @bera/hub:dev: ⨯ Internal error: Error: Image with src "https://res.cloudinary.com/duv0g402y/image/upload/f_auto,q_auto/v1/station/pools-bg.png" is missing required "width" property.
|
OK I've updated this to use the same insets (breakpoints) as exist in the container + updated the mobile design
It seems like the design we're using a different aspect ratio for the banner for mobile views, if we really need that we can do it as well (its better to do when we have the final asset really) |
|
Here are some UI feedback: Screen 1) There is no drop shadow/blur at the top and you can see a border that is not there on figma. Needs to be added to the menu bar. |
|
thanks! will circle back to this when I have a banner with a taller aspect ratio |
…issue with text colour tag in the wrong level
…tio we can maintain that is responsive.
|
ok managed to rework this to handle the mobile view per the figma. I think what's left is to set a max width as well / potentially render a the higher res asset edit: OK we're getting a higher res asset ETA soon. |
This:
Things we should consider: