Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #17

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix #17

merged 1 commit into from
Jan 10, 2025

Conversation

abi87
Copy link

@abi87 abi87 commented Jan 10, 2025

While load testing a small network we ended up stalling the network for some time (up to 303 rounds).
In such a situation the checks (and some logs too) on block timestamp in CometBFT are faulty (likely an overflow).
This patch skips the timestamp verifications once 10 rounds have passed.
A better fix should come where the (likely) overflow is duly handled.

@abi87 abi87 self-assigned this Jan 10, 2025
@abi87 abi87 requested a review from fridrik01 January 10, 2025 13:19
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fix". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - build
 - chore
 - ci
 - docs
 - refactor
 - perf
 - test
 - revert
 - spec
 - merge

General format: type(scope): msg
Breaking change: type(scope)!: msg
Multi-scope change: type: msg
Types: feat, fix, build, chore, ci, docs, refactor, perf, test, revert, spec, merge.
Example: fix(cmd/cometbft/commands/debug): execute p.Signal only when p is not nil

@abi87 abi87 merged commit e2a0300 into bera-v1.x Jan 10, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants