address comment. fixed missing enterNewRound

berachain · Jan 11, 2025 · 5293186 · 5293186
1 parent 42d65c8
commit 5293186
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/internal/consensus/reactor.go b/internal/consensus/reactor.go
@@ -942,7 +942,6 @@ func sendEntireCommit(logger log.Logger,
 		// }
 	}
 	return nil
-
 }
 
 func pickVoteToSend(

diff --git a/internal/consensus/state.go b/internal/consensus/state.go
@@ -2626,11 +2626,8 @@ func (cs *State) AddCommit(commit *types.Commit, peerID p2p.ID) (added bool, err
 	cs.enterPrecommit(height, commit.Round)
 
 	cs.enterCommit(height, commit.Round)
-	// TODO Enable back. Does Commit have something similar? If not implement HasAll() for Commit
-	// skipTimeoutCommit := cs.state.NextBlockDelay == 0 && cs.config.TimeoutCommit == 0
-	// if skipTimeoutCommit && commit.HasAll() {
-	// 	cs.enterNewRound(cs.Height, 0)
-	// }
+	// We skip timeoutCommit as this function is hit only when the node is late
+	cs.enterNewRound(cs.Height, 0)
 
 	return added, err
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -942,7 +942,6 @@ func sendEntireCommit(logger log.Logger, @@
     		// }
     	}
     	return nil
     }
     func pickVoteToSend(
@@ Expand Down @@