feat(pbts): Adjusts PBTS metrics buckets (cometbft#2578)

Contributes to cometbft#2480
berachain · Mar 11, 2024 · 2f0dc67 · 2f0dc67
1 parent f8366fc
commit 2f0dc67
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/internal/consensus/metrics.gen.go b/internal/consensus/metrics.gen.go
diff --git a/internal/consensus/metrics.go b/internal/consensus/metrics.go
@@ -139,7 +139,7 @@ type Metrics struct {
 	// metric thus should drive the definition of values for the consensus
 	// parameter SynchronyParams.MessageDelay, used by the PBTS algorithm.
 	// metrics:Difference in seconds between the local time when a proposal message is received and the timestamp in the proposal message.
-	ProposalTimestampDifference metrics.Histogram `metrics_bucketsizes:"-1.5, -1.0, -0.5, 0, 0.5, 1.0, 1.5, 2.0, 2.5, 3.0, 3.5, 4.0, 6.0, 8.0, 10.0" metrics_labels:"is_timely"`
+	ProposalTimestampDifference metrics.Histogram `metrics_bucketsizes:"-1.5, -1.0, -0.5, -0.2, 0, 0.2, 0.5, 1.0, 1.5, 2.0, 2.5, 4.0, 8.0" metrics_labels:"is_timely"`
 }
 
 func (m *Metrics) MarkProposalProcessed(accepted bool) {

diff --git a/types/params.go b/types/params.go
@@ -183,7 +183,7 @@ func DefaultFeatureParams() FeatureParams {
 }
 
 func DefaultSynchronyParams() SynchronyParams {
-	// TODO(@wbanfield): Determine experimental values for these defaults
+	// Default values determined based on experimental results and on
 	// https://github.com/tendermint/tendermint/issues/7202
 	return SynchronyParams{
 		Precision:    500 * time.Millisecond,