Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3/n] chore(types): Introduce DepositData and Deposit types for holding proofs #2290

Open
wants to merge 6 commits into
base: 4881-spec-tests
Choose a base branch
from

Conversation

calbera
Copy link
Contributor

@calbera calbera commented Dec 17, 2024

  • Consistent with ETH2 spec
  • old Deposit is now DepositData
  • Deposit now includes Proof: double check the SSZ impl according to karalabe/ssz
  • Flow of writing/reading deposits:
    • First Enqueue the DepositDatas (which comes from the EL events directly)
    • Then get the Deposits (with the proofs attached) from the store

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 73.42657% with 38 lines in your changes missing coverage. Please review.

Project coverage is 31.73%. Comparing base (76c153d) to head (566d431).

Files with missing lines Patch % Lines
consensus-types/types/deposit_data.go 84.70% 12 Missing and 1 partial ⚠️
cli/commands/genesis/collect.go 0.00% 5 Missing ⚠️
consensus-types/types/body.go 63.63% 3 Missing and 1 partial ⚠️
execution/deposit/contract.go 0.00% 3 Missing ⚠️
state-transition/core/validation_deposits.go 40.00% 1 Missing and 2 partials ⚠️
beacon/blockchain/pruning.go 0.00% 2 Missing ⚠️
consensus-types/types/deposits.go 33.33% 2 Missing ⚠️
consensus/cometbft/service/genesis.go 0.00% 2 Missing ⚠️
beacon/blockchain/deposit.go 0.00% 1 Missing ⚠️
beacon/blockchain/init_chain.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           4881-spec-tests    #2290      +/-   ##
===================================================
- Coverage            31.83%   31.73%   -0.11%     
===================================================
  Files                  337      338       +1     
  Lines                15772    15709      -63     
  Branches                20       20              
===================================================
- Hits                  5021     4985      -36     
+ Misses               10394    10375      -19     
+ Partials               357      349       -8     
Files with missing lines Coverage Δ
consensus-types/types/block.go 100.00% <ø> (+5.66%) ⬆️
consensus-types/types/genesis.go 87.50% <100.00%> (ø)
state-transition/core/state_processor_genesis.go 48.36% <ø> (ø)
state-transition/core/state_processor_staking.go 53.93% <100.00%> (ø)
storage/deposit/store.go 65.09% <100.00%> (+6.84%) ⬆️
beacon/blockchain/deposit.go 0.00% <0.00%> (ø)
beacon/blockchain/init_chain.go 0.00% <0.00%> (ø)
cli/commands/genesis/deposit.go 0.00% <0.00%> (ø)
consensus-types/types/deposit.go 43.75% <83.33%> (-40.96%) ⬇️
beacon/blockchain/pruning.go 0.00% <0.00%> (ø)
... and 7 more

@calbera calbera changed the title [WIP 3/n] chore(types): Introduce DepositData and Deposit types for holding proofs [3/n] chore(types): Introduce DepositData and Deposit types for holding proofs Dec 18, 2024
@calbera calbera marked this pull request as ready for review December 18, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant