Fix issue (#2177) #2276
Fix issue (#2177) #2276
Conversation
Signed-off-by: VolodymyrBg <[email protected]>
testing/e2e/config/config.go
Outdated
| @@ -13,7 +13,7 @@ | |||
| // LICENSOR AS EXPRESSLY REQUIRED BY THIS LICENSE). | |||
| // | |||
| // TO THE EXTENT PERMITTED BY APPLICABLE LAW, THE LICENSED WORK IS PROVIDED ON | |||
| // AN “AS IS” BASIS. LICENSOR HEREBY DISCLAIMS ALL WARRANTIES AND CONDITIONS, | |||
| // AN "AS IS" BASIS. LICENSOR HEREBY DISCLAIMS ALL WARRANTIES AND CONDITIONS, | |||
There was a problem hiding this comment.
please revert this change. We should fix all headings altogether if they are not right
| return jsonBytes | ||
| } | ||
|
|
||
| // ValidateNethermindConfig validates the Nethermind configuration | ||
| func (c *E2ETestConfig) ValidateNethermindConfig() error { |
There was a problem hiding this comment.
we can't know for sure if this solves Nethermind issues unless we make use of it.
In order to do that consider re-introducing nethermind replicas in testing/e2e/config/defaults.go in stead of geth or reth ones
There was a problem hiding this comment.
I agree, pls test the scenario mentioned in #2177 and share the results, that will help us in knowing if this fix really works. Thanks for your work!
|
Issue referred to #2177 |
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
| @@ -83,13 +83,14 @@ type NodeSettings struct { | |||
| ExecutionSettings ExecutionSettings `json:"execution_settings"` | |||
| } | |||
|
|
|||
| // ExecutionSettings holds the configuration for the execution layer | |||
| // clients. | |||
| // ExecutionSettings holds the configuration for the execution layer clients. | |||
There was a problem hiding this comment.
nit: not really required
testing/e2e/config/config.go
Outdated
| ConsensusConfig struct { | ||
| ForceSealing bool `json:"ForceSealing"` |
There was a problem hiding this comment.
ForceSealing is part of Aura namespace, pls check the correct usage. Refer https://docs.nethermind.io/fundamentals/configuration/#aura-forcesealing
I am curious why do we need it ?
Another point to note is it is true by default.
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Issue being referred to : #2177
What I changed in this file:
Special configuration for Nethermind
Methods for configuration management
Automatic setup of Nethermind parameters
Configuration validation capability
I think now when using Nethermind, optimized settings will be applied which should help resolve the block finalization issue.