3624 - Upgrade #4429

WillNigel23 · 2024-11-25T23:12:48Z

No description provided.

WillNigel23 · 2024-11-28T02:39:01Z

Some notable changes:

Ruby Version: 3.3.5

Rails Version 7.2.1

.to_s(:db) is deprecated. We now use .to_fs(:db) for formatting time string that is db compatible.
File.exists? and Dir.exists? methods are both now just .exist?
render syntax render 'namespace/partial.html is now not supported. We should remove the .html and instead pass it as formats: [:html]. Take a look at notes/note.html's past implementation and compare to now.
For handling .dot files like graph/graph.dot, we introduced new template handler for :dot files. Like Refactor bulk image import to use Rake instead of BackgrounDRb #3, we can pass it thru formats: [:dot]
I refactored interactors to inherit from ApplicationInteractor so that it follows a higher class architecture.
Some capybara methods are failing after update (due to not waiting for elements to fully load before accessing in tests). Adjusted these in legacy specs to use capybara methods that have built in wait implementation to avoid unnecessary timing errors.

TODO (likely on a future ticket)

Add hotwire turbo and move away from handling ajax requests server side
Migrate old js files to use importmaps syntax

WillNigel23 · 2024-11-28T02:46:48Z

Gemfile

-gem 'iiif-presentation', git: 'https://github.com/benwbrum/osullivan', branch: 'service_is_array'
-gem 'riiif', git: 'https://github.com/BrumfieldLabs/riiif.git', branch: 'quote-paths-for-shell'
+gem 'iiif-presentation'
+gem 'riiif'


Checked these forks and compared with main, it seems the changes applied here in forks are done already in main (merged from another PR I guess).

So we should be good to get these from main repo.

WillNigel23 · 2024-11-28T02:47:08Z

Gemfile

@@ -75,10 +78,6 @@ gem 'terser'

 gem 'interactor-rails', '~> 2.0'

-group :assets do
-  gem 'uglifier'
-end


Not used anymore

WillNigel23 · 2024-11-28T02:48:30Z

Gemfile

@@ -119,7 +118,7 @@ gem 'autoprefixer-rails'
 gem 'slim'

 # Gravatar Image Tag
-gem 'gravatar_image_tag'
+gem 'gravatar_image_tag', github: 'Tinix/gravatar_image_tag'


Original gravatar_image_tag gem is not updated anymore. It contains deprecated functions like URI.encode.

This fork addressed that. Though eventually we may want to move away totally from this (as I think gravatar_image is just an API after all so we maybe don't need our own gem for this)

WillNigel23 · 2024-11-28T02:50:45Z

app/controllers/article_controller.rb

+        link_max: link_max,
+        min_rank: min_rank
+      },
+      formats: [:dot]


We added new mime_type :dot, which is handled like erb (technically how it is being handled before, but the updated syntax fails so we needed to add this)

WillNigel23 · 2024-11-28T02:51:07Z

app/controllers/deed_controller.rb

@@ -32,12 +32,12 @@ def list

    # Scope for date
    if params[:start_date]
-      start_date = params[:start_date].to_datetime.to_s(:db)
+      start_date = params[:start_date].to_datetime.to_fs(:db)


to_s(:db) is deprecated, we now use to_fs(:db)

WillNigel23 · 2024-11-28T02:51:58Z

app/controllers/facets_controller.rb

@@ -95,7 +94,10 @@ def update

      redirect_to collection_facets_path(collection.owner, collection), notice: t('collection.facets.collection_facets_updated_successfully')
    else
-      render('collection/facets', :locals => { :@metadata_coverages => collection.metadata_coverages, :@errors => errors })


global variables now can't be passed thru locals. We should just declare the globals here then

WillNigel23 · 2024-11-28T02:52:27Z

app/controllers/notes_controller.rb

@@ -28,7 +28,7 @@ def create
    if @note.save
      record_deed
      render json: {
-        html: render_to_string(partial: 'note.html', locals: { note: @note }, formats: [:html]),
+        html: render_to_string(partial: 'note', locals: { note: @note }, formats: [:html]),


We pass in formats: [:html] instead of 'note.html' as that syntax is not supported anymore.

WillNigel23 · 2024-11-28T02:54:58Z

app/models/ahoy/event.rb


    belongs_to :visit, optional: true
    belongs_to :user, optional: true

-    serialize :properties, JSON
+    serialize :properties, coder: JSON


New syntax. Old one is failing.

WillNigel23 · 2024-11-28T02:55:14Z

app/models/document_upload.rb

    new: 'new',
    queued: 'queued',
    processing: 'processing',
    finished: 'finished',
    error: 'error'
-  }, _prefix: :status
+  }, prefix: :status


New enum syntax

WillNigel23 · 2024-11-28T02:55:27Z

app/models/ia_leaf.rb

-    unless File.exists?(cache_file_path)
-      unless Dir.exists?(cache_dir_path)
+    unless File.exist?(cache_file_path)
+      unless Dir.exist?(cache_dir_path)


Function was renamed

WillNigel23 · 2024-11-28T02:55:48Z

app/models/ia_work.rb

@@ -165,7 +165,7 @@ def ingest_work(id)

    self.save!
    # now fetch the scandata.xml file and parse it
-    scandata_url = "http://#{server}#{dir}/#{URI.encode(scandata_file)}" # will not work on new format: we cannot assume filenames are re-named with their content
+    scandata_url = "http://#{server}#{dir}/#{CGI.escape(scandata_file)}" # will not work on new format: we cannot assume filenames are re-named with their content


Deprecated function URI.encode is replaced by CGI.escape

WillNigel23 · 2024-11-28T02:56:49Z

config/i18n-tasks.yml

@@ -106,16 +106,34 @@ ignore_missing:
    - 'deed.deed.*'
    - 'article.graph.title'
    - 'thredded.*'
-  es: &NOT_EN


Not supported anymore. This seems to be a security vulnerability that i18n have patched long ago.

WillNigel23 · 2024-11-28T02:57:14Z

config/initializers/mime_types.rb

@@ -2,3 +2,6 @@

 # Add new mime types for use in respond_to blocks:
 # Mime::Type.register "text/richtext", :rtf
+
+Mime::Type.register 'text/vnd.graphviz', :dot
+ActionView::Template.register_template_handler :erb, ActionView::Template::Handlers::ERB.new


We register :dot handler

WillNigel23 force-pushed the 3624-upgrade branch 7 times, most recently from eda90ee to 5272089 Compare November 28, 2024 02:29

WillNigel23 commented Nov 28, 2024

View reviewed changes

WillNigel23 force-pushed the 3624-upgrade branch 4 times, most recently from 457c943 to 7eb7964 Compare December 2, 2024 17:49

3624 - Upgrade

1388260

WillNigel23 force-pushed the 3624-upgrade branch from 7eb7964 to 1388260 Compare December 2, 2024 17:52

saracarl mentioned this pull request Dec 29, 2024

3624 - Upgrade rails #4237

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3624 - Upgrade #4429

3624 - Upgrade #4429

WillNigel23 commented Nov 25, 2024

WillNigel23 commented Nov 28, 2024 •

edited

Loading

WillNigel23 Nov 28, 2024

WillNigel23 Nov 28, 2024

WillNigel23 Nov 28, 2024

WillNigel23 Nov 28, 2024

WillNigel23 Nov 28, 2024

WillNigel23 Nov 28, 2024

WillNigel23 Nov 28, 2024

WillNigel23 Nov 28, 2024

WillNigel23 Nov 28, 2024

WillNigel23 Nov 28, 2024

WillNigel23 Nov 28, 2024

WillNigel23 Nov 28, 2024

WillNigel23 Nov 28, 2024

3624 - Upgrade #4429

Are you sure you want to change the base?

3624 - Upgrade #4429

Conversation

WillNigel23 commented Nov 25, 2024

WillNigel23 commented Nov 28, 2024 • edited Loading

Some notable changes:

Ruby Version: 3.3.5

Rails Version 7.2.1

TODO (likely on a future ticket)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WillNigel23 commented Nov 28, 2024 •

edited

Loading