v1.4.0 (#10)

* Added DataFor(id) method to increase extensibility (#9)

* Added the dataFor() method to make the peerList actually extensible, this is a non breaking change

* Added unit test for dataFor() method support

* bump to v1.4.0

lib/index.js

@@ -51,19 +51,18 @@ module.exports = (opts) => {
 
         // add the peer
         const peerId = router.peerList.addPeer(req.query.peer_name, res)
-        const peerListStr = router.peerList.format()
 
         // send back the list of peers
         res.status(200)
             .set('Pragma', peerId)
             .set('Content-Type', 'text/plain')
-            .send(peerListStr)
+            .send(router.peerList.dataFor(peerId))
 
         // send an updated peer list to all peers
         router.peerList.getPeerIds().filter(id => id != peerId).forEach((id) => {
             // updated peer lists must always appear to come from
             // "ourselves", namely the srcId == destId
-            sendPeerMessage(id, id, peerListStr)
+            sendPeerMessage(id, id, router.peerList.dataFor(id))
         })
     })
 
@@ -123,14 +122,11 @@ module.exports = (opts) => {
         // remove the peer
         router.peerList.removePeer(req.query.peer_id)
 
-        // format the updated peerList
-        const peerListStr = router.peerList.format()
-
         // send an updated peer list to all peers
         router.peerList.getPeerIds().forEach((id) => {
             // updated peer lists must always appear to come from
             // "ourselves", namely the srcId == destId
-            sendPeerMessage(id, id, peerListStr)
+            sendPeerMessage(id, id, router.peerList.dataFor(id))
         })
 
         res.status(200).end()

lib/peer-list.js

@@ -21,6 +21,7 @@ module.exports = class PeerList {
         if (this._peers[id]) {
             delete this._peers[id]
         }
+
     }
 
     getPeer(id) {
@@ -63,4 +64,10 @@ module.exports = class PeerList {
                 return `${e.name},${e.id},${e.status() ? 1 : 0}`
             }).join('\n') + '\n'
     }
+
+    dataFor(id) {
+        //returns the data that should appear for a given ID
+        //This is the primary part of peer-list that is extensible
+        return this.format()
+    }
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "webrtc-signal-http",
-  "version": "1.3.0",
+  "version": "1.4.0",
   "description": "opinionated webrtc signal provider using http as a protocol",
   "main": "lib/index.js",
   "directories": {

test/basic.js

@@ -274,6 +274,20 @@ describe('webrtc-signal-http', () => {
 
             assert.equal(instance.format(), 'test2,2,0\ntest,1,0\n')
         })
+
+        it('should support formatting via dataFor() method', () => {
+            const instance = new PeerList()
+
+            instance.addPeer('test', { obj: true })
+
+            assert.equal(instance.dataFor('test'), 'test,1,0\n')
+
+            instance.addPeer('test2', { obj: true })
+
+            assert.equal(instance.dataFor('test2'), 'test2,2,0\ntest,1,0\n')
+        })
+
+
     })
 
     describe('Peer', () => {