Merge pull request #1630 from benetech/frontend_v2

#1620 - add title length validation
benetech · Jan 10, 2021 · 480a17f · 480a17f
2 parents 06d16fa + 7b16b3e
commit 480a17f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/components/Home/components/NewProblemsForm/styles.scss b/src/components/Home/components/NewProblemsForm/styles.scss
@@ -35,7 +35,7 @@ div.row {
 .container table {
     width: calc(100% - 20px);
     margin: 10px;
-    min-width: 950px;
+    table-layout: fixed;
 
     .headerRow {
         th[scope='col'] {
@@ -75,7 +75,9 @@ div.row {
 }
 
 .titleCell {
-    width: 320px;
+    width: 350px;
+    padding-left: 10px;
+    padding-right: 45px;
 }
 
 .tableControlHeader {
@@ -92,6 +94,8 @@ div.row {
     cursor: pointer;
     display: flex;
     justify-content: flex-end;
+    background: white;
+    position: relative;
 
     > span {
         display: inherit;

diff --git a/src/components/index.js b/src/components/index.js
@@ -171,6 +171,8 @@ class App extends Component {
             } else {
                 message = Locales.strings.no_problem_title_warning;
             }
+        } else if ($.trim(text).length > 2000) {
+            message = Locales.strings.title_max_length;
         } else if (problemList.theActiveMathField.$latex() === '' && image === null) {
             message = Locales.strings.no_problem_equation_or_image_warning;
         }

diff --git a/src/strings.js b/src/strings.js
@@ -401,6 +401,7 @@ class Locales {
                 thanks_for_mobile_notfiy: 'Thanks, we will notify you once we add mobile compatibility',
                 the: 'The',
                 title: 'Title',
+                title_max_length: 'Max length of title is 2000 characters',
                 to_mathshare_twitter: 'Twitter',
                 to_mathshare_youtube: 'YouTube',
                 to_track: 'to track your problem sets',