MTN use benchopt 1.5 API #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mathurinm benchmark is up to date with |
|
(closed/reopened to trigger the tests, after reenabling the workflow that had been disabled due to inactivity on the repo) |
mathurinm
reviewed
Jul 16, 2024
|
Thanks heaps @wassimmazouz ! |
mathurinm
reviewed
Sep 4, 2024
| 'isotropy': ["anisotropic", "isotropic"], | ||
| 'data_fit': ["lsq", "huber"]} | ||
|
|
||
| def __init__(self, reg=0.02, delta=0.1, |
There was a problem hiding this comment.
@wassimmazouz was there a particular reason to remove the init ? this slipped through
There was a problem hiding this comment.
there is no need for __init__ to pass the parameters as we do this directly with benchopt, so removing it avoids having duplicated code, that you need to keep up to date when adding new parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.